Skip to content

ref(node): Streamline koa#21554

Merged
nicohrubec merged 1 commit into
developfrom
ref/streamline-koa
Jun 16, 2026
Merged

ref(node): Streamline koa#21554
nicohrubec merged 1 commit into
developfrom
ref/streamline-koa

Conversation

@nicohrubec

@nicohrubec nicohrubec commented Jun 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Streamlines the vendored @opentelemetry/instrumentation-koa:

  • Replaces OTel tracer API calls with Sentry core startSpan.
  • Moved the op/origin/name/transaction-name logic from the integration's requestHook directly into the instrumentation's startSpan call, and dropped the now-unused requestHook logic/types.
  • Ported unit tests for isLayerIgnored from otel.
  • Added e2e coverage for the paths the existing app missed: RegExp/nested routers, middleware dedup (kLayerPatched), and errored layer-span status.
  • Clean out unused OTel diag debug logs.
  • Remove eslint-disable and oxlint no-explicit-any exemption (any → typed/unknown).

Closes #20734

@github-actions

github-actions Bot commented Jun 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 27.4 kB - -
@sentry/browser - with treeshaking flags 25.84 kB - -
@sentry/browser (incl. Tracing) 45.7 kB - -
@sentry/browser (incl. Tracing + Span Streaming) 47.94 kB - -
@sentry/browser (incl. Tracing, Profiling) 50.5 kB - -
@sentry/browser (incl. Tracing, Replay) 84.92 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 74.53 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 89.61 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 102.3 kB - -
@sentry/browser (incl. Feedback) 44.56 kB - -
@sentry/browser (incl. sendFeedback) 32.2 kB - -
@sentry/browser (incl. FeedbackAsync) 37.31 kB - -
@sentry/browser (incl. Metrics) 28.47 kB - -
@sentry/browser (incl. Logs) 28.71 kB - -
@sentry/browser (incl. Metrics & Logs) 29.4 kB - -
@sentry/react 29.2 kB - -
@sentry/react (incl. Tracing) 48 kB - -
@sentry/vue 32.42 kB - -
@sentry/vue (incl. Tracing) 47.59 kB - -
@sentry/svelte 27.42 kB - -
CDN Bundle 29.79 kB - -
CDN Bundle (incl. Tracing) 48.2 kB - -
CDN Bundle (incl. Logs, Metrics) 31.33 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) 49.49 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) 70.62 kB - -
CDN Bundle (incl. Tracing, Replay) 85.52 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 86.77 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 91.37 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 92.62 kB - -
CDN Bundle - uncompressed 88.59 kB - -
CDN Bundle (incl. Tracing) - uncompressed 145.8 kB - -
CDN Bundle (incl. Logs, Metrics) - uncompressed 93.29 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 149.77 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 218.12 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 264.67 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 268.63 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 278.37 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 282.31 kB - -
@sentry/nextjs (client) 50.45 kB - -
@sentry/sveltekit (client) 46.12 kB - -
@sentry/core/server 76.08 kB - -
@sentry/core/browser 63.22 kB - -
@sentry/node-core 61.73 kB +0.01% +3 B 🔺
@sentry/node 128.67 kB -0.14% -170 B 🔽
@sentry/node - without tracing 74.1 kB - -
@sentry/aws-serverless 86.35 kB - -
@sentry/cloudflare (withSentry) - minified 174.19 kB - -
@sentry/cloudflare (withSentry) 435.41 kB - -

View base workflow run

@nicohrubec nicohrubec force-pushed the ref/streamline-koa branch 4 times, most recently from 89e7d4b to fffbf52 Compare June 16, 2026 07:07
@nicohrubec @claude
ref(node): Streamline koa
a444a94 
Migrate koa span creation to the @sentry/core API, fold the op/origin/name/transaction-name requestHook into span creation, and remove the vendored files' eslint-disable + no-explicit-any exemption. Extend the node-koa e2e for RegExp/nested routers, middleware dedup, and errored-span status, and port the isLayerIgnored unit test.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@nicohrubec nicohrubec force-pushed the ref/streamline-koa branch from fffbf52 to a444a94 Compare June 16, 2026 07:16
@nicohrubec nicohrubec marked this pull request as ready for review June 16, 2026 07:58
@nicohrubec nicohrubec requested a review from a team as a code owner June 16, 2026 07:58
@nicohrubec nicohrubec requested review from JPeer264, andreiborza and mydea and removed request for a team June 16, 2026 07:58
JPeer264
JPeer264 approved these changes Jun 16, 2026
View reviewed changes

@JPeer264 JPeer264 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@nicohrubec nicohrubec merged commit e103431 into develop Jun 16, 2026
273 checks passed
@nicohrubec nicohrubec deleted the ref/streamline-koa branch June 16, 2026 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JPeer264 JPeer264 JPeer264 approved these changes

@mydea mydea Awaiting requested review from mydea mydea is a code owner automatically assigned from getsentry/team-javascript-sdks-server

@andreiborza andreiborza Awaiting requested review from andreiborza

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Streamline @opentelemetry/instrumentation-koa

2 participants

@nicohrubec @JPeer264